Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42919 )
Change subject: [RFC] supermicro/x11-lga1151/gpio: 5/5 Remap reset sources
......................................................................
Patch Set 6:
so what exactly is the net effect of this patchset? In the process of converting from the raw dataword values to macros, you've obviously changed quite a bit in the way coreboot sets these GPIOs, in terms of values/features set.
Is there a reason to make these changes, other than the macros providing a clearer indication of how the GPIO is set/used? If not, do the changes affect how the GPIOs function? If yes, how?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42919
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I388d39ca8314de60610588223d024e1bb1681264
Gerrit-Change-Number: 42919
Gerrit-PatchSet: 6
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 06 Jul 2020 16:24:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment