Attention is currently required from: Nikolai Vyssotski.
chris wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48864 )
Change subject: soc/amd/picasso: Add UPDs for support eDP power sequence adjust
......................................................................
Patch Set 10:
(2 comments)
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48864/comment/06667c06_513a8706
PS6, Line 251: uint8_t edp_pwr_adjust_enable;
It is maybe worth mentioning here that all the values below are in units of 4ms as you have in commi […]
Done
https://review.coreboot.org/c/coreboot/+/48864/comment/fe9d2147_6e1c625c
PS6, Line 252: pwron_digon_to_De
Odd variable name. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48864
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6eceebd1c3f522e6a8dfaadc487a590107ae3131
Gerrit-Change-Number: 48864
Gerrit-PatchSet: 10
Gerrit-Owner: chris wang
Chris.Wang@amd.com
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-Comment-Date: Thu, 21 Jan 2021 12:48:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Vyssotski
nikolai.vyssotski@amd.corp-partner.google.com
Gerrit-MessageType: comment