Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/18561 )
Change subject: AGESA binaryPI: Flip HUDSON_IMC_FWM default to disabled ......................................................................
Patch Set 2: Code-Review-1
(2 comments)
Do you plan to add selects to mainboards in this patch? It looks like it should not be selected in any Mullins or Kabini. Also not in asus/f2a85, msi/ms7721, pcengines/apu2. I'd probably select all others for consistency.
https://review.coreboot.org/#/c/18561/2/src/southbridge/amd/agesa/hudson/Kco... File src/southbridge/amd/agesa/hudson/Kconfig:
PS2, Line 68: USE_BLOBS I would prefer not to have this dependency. Explanation in next file, but I'm less opinionated for this one.
https://review.coreboot.org/#/c/18561/2/src/southbridge/amd/pi/hudson/Kconfi... File src/southbridge/amd/pi/hudson/Kconfig:
PS2, Line 71: USE_BLOBS I would prefer to not have this dependency. USE_BLOBS is primarily an instruction to the build to pull down the blobs repo vs. permission to use blobs in the build. I might already have blobs locally and not want to set this symbol. Also, all PI systems will require blobs to run anyway.