Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/73384 )
Change subject: mb/intel/mtlrvp: Enable RTD3 root port mutex for WWAN ......................................................................
mb/intel/mtlrvp: Enable RTD3 root port mutex for WWAN
This adds RTD3 RPMX mutex to the root port. It is shared between RTD3 and WWAN. The purpose of using this mutex is to prevent OSPM from calling _ON and _OFF methods while WWAN kernel driver is calling _RST, which accesses the GPIO pins.
BUG=NA TEST=boot to OS and check the generated SSDT table for the root port. The RPMX mutex should be generated under the root port.
Signed-off-by: Cliff Huang cliff.huang@intel.com Change-Id: I5b53765453bac0fc96e9651ab347069c7c8bf058 Reviewed-on: https://review.coreboot.org/c/coreboot/+/73384 Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Bora Guvendik bora.guvendik@intel.com Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com --- M src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb 1 file changed, 25 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Bora Guvendik: Looks good to me, but someone else must approve Jérémy Compostella: Looks good to me, but someone else must approve Martin Roth: Looks good to me, approved
diff --git a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb index e80c542..66f2179 100644 --- a/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb +++ b/src/mainboard/intel/mtlrvp/variants/baseboard/mtlrvp_p/devicetree.cb @@ -297,6 +297,7 @@ register "srcclk_pin" = "1" register "ext_pm_support" = "ACPI_PCIE_RP_EMIT_ALL" register "skip_on_off_support" = "true" + register "use_rp_mutex" = "true" device generic 0 alias rp7_rtd3 on end end chip drivers/wwan/fm