Nicholas Chin has posted comments on this change by Nicholas Chin. ( https://review.coreboot.org/c/coreboot/+/84099?usp=email )
Change subject: mb/dell/snb_ivb_latitude: Use macros for azalia config ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/dell/snb_ivb_latitude/variants/e5420/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/84099/comment/fdba2fe0_a81b8535?usp... : PS1, Line 28: 0x400000f0 These probably could be safely replaced with AZALIA_PIN_CFG_NC(0), though that expands to 0x411111f0 and would change the build. Might change it in a separate patch so that this one doesn't affect the build and can be more easily verified.