[coreboot-gerrit] Change in coreboot[master]: soc/intel/cnl: add panel and backlight configuration code

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48749 )

Change subject: soc/intel/cnl: add panel and backlight configuration code
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr... 
File src/soc/intel/cannonlake/graphics.c:

https://review.coreboot.org/c/coreboot/+/48749/2/src/soc/intel/cannonlake/gr... 
PS2, Line 3: #include <commonlib/helpers.h>
           : #include <device/device.h>
           : #include <device/mmio.h>
           : #include <device/pci_def.h>
           : #include <device/resource.h>
           : #include <drivers/intel/gma/i915.h>
           : #include <drivers/intel/gma/i915_reg.h>
           : #include <intelblocks/graphics.h>
           : #include <soc/ramstage.h>
           : #include <types.h>
           :
> `ramstage.h` was confusing me, it's a substitute for "chip.h". […]

yeah, it looked cleaner than include "chip.h", but it really doesn't matter