Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32772 )
Change subject: post_code: add post code for invalid vendor binary
......................................................................
Patch Set 4:
Patch Set 4:
Patch Set 4:
(1 comment)
Patch Set 4:
checks on mrc.bin are missing
Can you elaborate a little more please? Is there a specific file you are seeing checks on mrc.bin missing in?
void sdram_initialize(struct pei_data *pei_data) in
src/northbridge/intel/sandybridge/raminit_mrc.c
src/northbridge/intel/haswell/raminit.c
Sure, if those are the same issue, it doesn't hurt to update them.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32772
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib1e359d4e8772c37922b1b779135e58c73bff6b4
Gerrit-Change-Number: 32772
Gerrit-PatchSet: 4
Gerrit-Owner: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Keith Short
keithshort@chromium.org
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jett Rink
jettrink@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 21 May 2019 17:40:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment