Attention is currently required from: Paul Menzel, Stefan Reinauer, Tim Wawrzynczak, Patrick Rudolph. Curtis Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59644 )
Change subject: soc/intel/alderlake: Add TDP to give correct VR configuration ......................................................................
Patch Set 4:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/59644/comment/1aa8e98a_2974a4e3 PS1, Line 7: soc/intel/alderlake: Add TDP to give correct VR configuration.
Please remove the dot/period at the end [1]. […]
Done
https://review.coreboot.org/c/coreboot/+/59644/comment/6265ac3a_4c5a5cdf PS1, Line 11: Add TDP to recognize the correct SKU and give the correct power setting.
Please add a blank line between paragraphs.
Done
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/59644/comment/e6271648_d1624fb8 PS1, Line 42: 34250
Is this just gerrit?
Done
File src/soc/intel/alderlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/59644/comment/dc953d0e_7795286c PS1, Line 36: u8 tdp;
Please be consistent, so `uint8_t`.
Done
https://review.coreboot.org/c/coreboot/+/59644/comment/0de87b1c_efc57a11 PS1, Line 83: { PCI_DEVICE_ID_INTEL_ADL_P_ID_3, 28, VR_CFG_ALL_DOMAINS_TDC_CURRENT(40, 40) },
That line is new. […]
Done
https://review.coreboot.org/c/coreboot/+/59644/comment/6fc67815_49e300ae PS1, Line 111: u8
ditto
Done