Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85774?usp=email )
Change subject: soc/mediatek/mt8196: Add dynamic power-saving for peripheral clocks ......................................................................
Patch Set 5:
(3 comments)
File src/soc/mediatek/mt8196/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/85774/comment/ed214ef0_c9493979?usp... : PS3, Line 137: PERI_MASK_IDLE_TO_CKSYS = IO_PHYS + 0x06630270,
I think this file is supposed to have only base registers, not all the registers we need. […]
Done
File src/soc/mediatek/mt8196/mtk_cksys.c:
PS3:
No need to add mtk_ to the file name. We don't use that prefix for other files. […]
Done
https://review.coreboot.org/c/coreboot/+/85774/comment/81ba9c3e_c406145b?usp... : PS3, Line 6: mtk_cksys
Same for the header file name. Can we use cksys. […]
Done