Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46878 )
Change subject: soc/mediatek/mt8192: add clkbuf and srclken_rc MT6359P driver
......................................................................
Patch Set 40:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46878/39/src/soc/mediatek/mt8192/in...
File src/soc/mediatek/mt8192/include/soc/rtc.h:
https://review.coreboot.org/c/coreboot/+/46878/39/src/soc/mediatek/mt8192/in...
PS39, Line 151: #if 0
I will move this patch to the tail of the chain and have few rounds of review with Ran Bi first.
Okay. Please notify me when this is ready.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46878
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I947bf14df7a307bf359c590c2a20265882b3f1be
Gerrit-Change-Number: 46878
Gerrit-PatchSet: 40
Gerrit-Owner: Roger Lu
roger.lu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Ran Bi
ran.bi@mediatek.com
Gerrit-Reviewer: Roger Lu
roger.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Yuchen Huang
yuchen.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Fri, 25 Dec 2020 07:13:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yidi Lin
yidi.lin@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment