Attention is currently required from: Tarun Tuli, Kapil Porwal, Sumeet R Pawnikar, Eric Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74379 )
Change subject: mb/google/rex: Add CPU power limit values ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: Please split this CL into 2 Cls
1. mainboard.c and variant.h
2. Makefile.inc and ramstage.c
File src/mainboard/google/rex/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/143956ee_271edd7a PS2, Line 36: variant_devtree_update why we need to do this override for per variant rather than baseboard ?
for example: both rex and screebo will use same 281 SoC hence, the MTL MCH ID will be same.
what would benefit to repeat this going forward for all 30+ variants in scope of rex baseboard using all same SoC SPEC#
I would have allow to have baseboard specific override for example:rex being the baseboard for all chromebooks with MTL SoC can leverage this. Also allow Ovis baseboard(for chromebox) with MTL SoC (may be 28W) can use the baseboard specific override.
File src/mainboard/google/rex/variants/rex0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/74379/comment/c6db7ee1_e26b915e PS2, Line 17: } I prefer to make it visible to know what we are filling into.
``` void variant_devtree_update(void) { struct cpu_power_limits limits[] = { { .mchid = 123, .cpu_tdp = 15, .pl1_min_power = 6000, .pl1_max_power = 15000, .pl2_min_power = 57000, .pl2_max_power = 57000, .pl4_power = 101000, }, }; size_t total_entries = ARRAY_SIZE(limits); variant_update_power_limits(limits, total_entries); } ```