Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43846 )
Change subject: soc/skylake: Enable DCI depending on devicetree configuration
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43846/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43846/2//COMMIT_MSG@13
PS2, Line 13: I checked all corresponding mainboards if the devicetree
: configuration matches the PchDciEn setting.
You didn't, hence the -1? I see lots of "device pci 14.1 on end". […]
That's why the -1: https://review.coreboot.org/c/coreboot/+/43846/2#message-da5583cac770dcfa604...
But I just found out that DCI != xDCI. Looks like xDCI is just "normal" OTG without allowing root access to the CPU. For xDCI there is XdciEnable.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43846
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic816655d87cee9e56520aa30fc3c837b561f24e5
Gerrit-Change-Number: 43846
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 25 Jul 2020 10:43:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment