Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34005 )
Change subject: drivers/intel: Move FSP stage_cache implementation into common block
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34005/3/src/soc/intel/common/block/...
File src/soc/intel/common/block/smm/smm.c:
https://review.coreboot.org/c/coreboot/+/34005/3/src/soc/intel/common/block/...
PS3, Line 28: !CONFIG(PLATFORM_USES_FSP1_1)
In that case, why is a guard needed here at all?
SKL is still using FSP1.1 and it also usage intel common code
Error here : https://qa.coreboot.org/job/coreboot-gerrit/97623/#showFailuresLink
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebb6d698c236a95162b3c7eb07987483a293b50a
Gerrit-Change-Number: 34005
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jul 2019 02:32:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment