[coreboot-gerrit] Change in coreboot[master]: src/soc/amd/common/fsp: check FSP binary version.

[Name of user not set (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Julian Schroeder, Felix Held.
Name of user not set #1003801 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58869 )

Change subject: src/soc/amd/common/fsp: check FSP binary version.
......................................................................

Patch Set 1:

(1 comment)

File src/drivers/intel/fsp2_0/util.c:

https://review.coreboot.org/c/coreboot/+/58869/comment/d9e74e18_592d8e41 
PS1, Line 80: 	struct fsp_info_header *info = (struct fsp_info_header *) (fsp_file + FSP_INFO_HEADER_OFF);
> ok, an also hdr->revision. […]

at offset 0x94 we have a fsp_info_header,not a fsp_header. the two structures are different. After all the AMD image revision value shows up at the correct place in the fsp_info_header. fsp_revision holds information pertaining to the FSP standard and does not encode AMD binary version information.