Attention is currently required from: Julius Werner, Lance Zhao, Tim Wawrzynczak.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76132?usp=email )
Change subject: acpi: Add functions to declare ARM GIC V3 hardware
......................................................................
Patch Set 5:
(2 comments)
File src/arch/arm64/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/76132/comment/54ed1509_ed66329c :
PS5, Line 122: ramstage-$(CONFIG_ACPI_COMMON_MADT_GICC_V3) += ../../acpi/acpi_gic.c
Why put that here and not in acpi/Makefile.inc?
Similar to how arch/x86 includes apic/hpet/dmar acpi code.
File src/include/acpi/acpi.h:
https://review.coreboot.org/c/coreboot/+/76132/comment/271beb87_fd951b07 :
PS5, Line 1571: uintptr_t get_gicr_base(void);
These are platform callbacks, right? They should probably be a bit better namespaced, e.g. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76132?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5074d0a76316e854b7801e14b3241f88e805b02f
Gerrit-Change-Number: 76132
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Lance Zhao
lance.zhao@gmail.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 02 Aug 2023 07:41:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment
