Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44642 )
Change subject: soc/amd/common: add rudimentary ATIF support ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44642/1/src/soc/amd/common/block/gr... File src/soc/amd/common/block/graphics/graphics.c:
https://review.coreboot.org/c/coreboot/+/44642/1/src/soc/amd/common/block/gr... PS1, Line 101:
There's no notion of a consistent return value. I don't know what we could do there. […]
Makes sense. Yeah, I did not find any consistent return value that could indicate error. I think what we have here is good.