Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38143 )
Change subject: mb/asus/p5qc: Add ASUS P5Q as a variant (with documentation) ......................................................................
Patch Set 13:
(4 comments)
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... File Documentation/mainboard/asus/p5q.md:
https://review.coreboot.org/c/coreboot/+/38143/12/Documentation/mainboard/as... PS12, Line 27: No?
Deleted since chip is socketed
Ack
https://review.coreboot.org/c/coreboot/+/38143/13/Documentation/mainboard/as... File Documentation/mainboard/asus/p5q.md:
https://review.coreboot.org/c/coreboot/+/38143/13/Documentation/mainboard/as... PS13, Line 8: Add:
+ All 4 DIMM slots + S3 suspend and resume + Red SATA ports
https://review.coreboot.org/c/coreboot/+/38143/13/Documentation/mainboard/as... PS13, Line 19: ATA PATA
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... File src/mainboard/asus/p5qc/variants/p5q/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38143/1/src/mainboard/asus/p5qc/var... PS1, Line 71: device pnp 2e.0 off end # FDC : device pnp 2e.1 off end # LPT1 : device pnp 2e.2 on # COM1 : # Global registers : irq 0x2a = 0x00 : irq 0x2c = 0x22 : irq 0x2d = 0x00 : io 0x60 = 0x3f8 : irq 0x70 = 4 : end
I connected my old FDD to test it but OS didn't detect floppy disk […]
Floppy is still off on the last patchset, no wonder why it doesn't work :D