29 Aug
2024
29 Aug
'24
3:39 a.m.
Attention is currently required from: Elyes Haouas.
Felix Singer has posted comments on this change by Elyes Haouas. ( https://review.coreboot.org/c/coreboot/+/71585?usp=email )
Change subject: soc/intel/skylake/Makefile.inc: Remove path to non-existent directories ......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/skylake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/71585/comment/db401955_21611c96?usp... : PS5, Line 112: ifeq ($(CONFIG_BOARD_STARLABS_STARBOOK_ADL) $(CONFIG_BOARD_STARLABS_LABTOP_CML) $(CONFIG_BOARD_STARLABS_STARBOOK_TGL) $(CONFIG_BOARD_OCP_TIOGAPASS),y)
How did this pass the review? All of these don't use a Skylake SoC.
Please be more careful. CB:84127
--
To view, visit https://review.coreboot.org/c/coreboot/+/71585?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc43e40514a12944fa180197ffe3230ff9800de9
Gerrit-Change-Number: 71585
Gerrit-PatchSet: 5
Gerrit-Owner: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Elyes Haouas ehaouas@noos.fr
Gerrit-Reviewer: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com
Gerrit-CC: Felix Singer service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Elyes Haouas ehaouas@noos.fr
Gerrit-Comment-Date: Thu, 29 Aug 2024 03:39:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer service+coreboot-gerrit@felixsinger.de