Paul Fagerburg has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43419 )
Change subject: util/mb/google: add template files for dalboz and trembyle ......................................................................
util/mb/google: add template files for dalboz and trembyle
Now that Zork is using upstream coreboot, we need the template files in the main branch.
BUG=b:157570490 TEST=n/a
Signed-off-by: Paul Fagerburg pfagerburg@chromium.org Change-Id: I6cab4ab0b414473e0a759dce81df9872a40d3f26 Reviewed-on: https://review.coreboot.org/c/coreboot/+/43419 Reviewed-by: Raul Rangel rrangel@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A util/mainboard/google/dalboz/template/Makefile.inc A util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl A util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl A util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl A util/mainboard/google/dalboz/template/include/variant/ec.h A util/mainboard/google/dalboz/template/include/variant/gpio.h A util/mainboard/google/dalboz/template/include/variant/thermal.h A util/mainboard/google/dalboz/template/overridetree.cb A util/mainboard/google/trembyle/template/Makefile.inc A util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl A util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl A util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl A util/mainboard/google/trembyle/template/include/variant/ec.h A util/mainboard/google/trembyle/template/include/variant/gpio.h A util/mainboard/google/trembyle/template/include/variant/thermal.h A util/mainboard/google/trembyle/template/overridetree.cb 16 files changed, 131 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Raul Rangel: Looks good to me, approved
diff --git a/util/mainboard/google/dalboz/template/Makefile.inc b/util/mainboard/google/dalboz/template/Makefile.inc new file mode 100644 index 0000000..9dc5159 --- /dev/null +++ b/util/mainboard/google/dalboz/template/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ../baseboard/spd diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl b/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/util/mainboard/google/dalboz/template/include/variant/ec.h b/util/mainboard/google/dalboz/template/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/util/mainboard/google/dalboz/template/include/variant/gpio.h b/util/mainboard/google/dalboz/template/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/util/mainboard/google/dalboz/template/include/variant/thermal.h b/util/mainboard/google/dalboz/template/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/util/mainboard/google/dalboz/template/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/util/mainboard/google/dalboz/template/overridetree.cb b/util/mainboard/google/dalboz/template/overridetree.cb new file mode 100644 index 0000000..7645ba3 --- /dev/null +++ b/util/mainboard/google/dalboz/template/overridetree.cb @@ -0,0 +1,42 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #56670 Chapter 5 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "1" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "6000" #mw + register "fast_ppt_limit" = "9000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "2500" #second + register "sustained_power_limit" = "4800" #mw + + # End : OPN Performance Configuration + + # I2C2 for touchscreen and trackpad + + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + }" + + # I2C3 for H1 + + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + end # domain + + device mmio 0xfedc4000 on # APU_I2C2_BASE + end # device + +end # chip soc/amd/picasso diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.inc new file mode 100644 index 0000000..9dc5159 --- /dev/null +++ b/util/mainboard/google/trembyle/template/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ../baseboard/spd diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl new file mode 100644 index 0000000..900e36f --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/audio.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/audio.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl new file mode 100644 index 0000000..a1161ed --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/mainboard.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/mainboard.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl b/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl new file mode 100644 index 0000000..7a793d8 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/acpi/thermal.asl @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/acpi/thermal.asl> diff --git a/util/mainboard/google/trembyle/template/include/variant/ec.h b/util/mainboard/google/trembyle/template/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/util/mainboard/google/trembyle/template/include/variant/gpio.h b/util/mainboard/google/trembyle/template/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/util/mainboard/google/trembyle/template/include/variant/thermal.h b/util/mainboard/google/trembyle/template/include/variant/thermal.h new file mode 100644 index 0000000..2af6479 --- /dev/null +++ b/util/mainboard/google/trembyle/template/include/variant/thermal.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/thermal.h> diff --git a/util/mainboard/google/trembyle/template/overridetree.cb b/util/mainboard/google/trembyle/template/overridetree.cb new file mode 100644 index 0000000..d332fce --- /dev/null +++ b/util/mainboard/google/trembyle/template/overridetree.cb @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/picasso + + # Start : OPN Performance Configuration + # See devhub #55593 Chapter 3.2 for documentation + # For the below fields, 0 indicates use SOC default + + # System config index + register "system_config" = "2" + + # Set STAPM confiuration. All of these fields must be set >0 to take affect + register "slow_ppt_limit" = "25000" #mw + register "fast_ppt_limit" = "30000" #mw + register "slow_ppt_time_constant" = "5" #second + register "stapm_time_constant" = "200" #second + register "sustained_power_limit" = "15000" #mw + + register "telemetry_vddcr_vdd_slope" = "71222" #mA + register "telemetry_vddcr_vdd_offset" = "0" + register "telemetry_vddcr_soc_slope" = "28977" #mA + register "telemetry_vddcr_soc_offset" = "0" + + # End : OPN Performance Configuration + + # Enable I2C2 for trackpad, touchscreen, pen at 400kHz + register "i2c[2]" = "{ + .speed = I2C_SPEED_FAST, + }" + + # Enable I2C3 for H1 400kHz + register "i2c[3]" = "{ + .speed = I2C_SPEED_FAST, + .early_init = true, + }" + + # See AMD 55570-B1 Table 13: PCI Device ID Assignments. + device domain 0 on + subsystemid 0x1022 0x1510 inherit + device pci 1.6 off end # GPP Bridge 5 + device pci 1.7 on end # GPP Bridge 6 - NVME + device pci 14.6 off end # Non-Functional SDHCI + end # domain + + device mmio 0xfedc4000 on end + +end # chip soc/amd/picasso