Attention is currently required from: Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Tim Chu, Shelly_Chang@wiwynn.com.
Hello build bot (Jenkins), Jonathan Zhang, Christian Walter, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Shelly_Chang@wiwynn.com, Tim Chu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/58100
to look at the new patch set (#5).
Change subject: mb/ocp/deltalake: Fix SMBIOS type 9 bugs
......................................................................
mb/ocp/deltalake: Fix SMBIOS type 9 bugs
1. Fix PCIe slot capabilities was not really read from an IIO root port
device. The Hot-Plug capability of IIO root port cannot be enabled
due to FSP limitation, but the code should reflect the true
capabilities by reading the root port device's CSR.
2. Initiailize the characteristics flags to 0 in the for-loop.
Tested=On OCP Delta Lake, dmidecode -t 9 shows expected results.
Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com
---
M src/mainboard/ocp/deltalake/ramstage.c
1 file changed, 13 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/58100/5
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58100
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea437cdf3da5410b6b7a749a1be970f0948d92d9
Gerrit-Change-Number: 58100
Gerrit-PatchSet: 5
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Shelly_Chang@wiwynn.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Shelly_Chang@wiwynn.com
Gerrit-MessageType: newpatchset