[coreboot-gerrit] [XS] Change in coreboot[master]: arch/x86/smbios: Add weak function for BIOS Vendor in SMBIOS Type0

[Martin Roth (Code Review)]

Attention is currently required from: Angel Pons, Arthur Heymans, Eric Lai, Felix Held, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Subrata Banik, TangYiwei, Ziang Wang, [e-mail].

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75737?usp=email )

Change subject: arch/x86/smbios: Add weak function for BIOS Vendor in SMBIOS Type0
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> I think "vendor" in SMBIOS type 0 specifies the BIOS image provider on the mother board not the code […]

The SMBIOS specification isn't clear on what they mean by "BIOS Vendor's Name", but it seems reasonable to me that this would be who built the firmware.

Based on that, I think this should be patch should changed to use a Kconfig option that defaults to 'coreboot', and that the default for all platforms in the coreboot tree should remain coreboot. Using weak function like this will update the ID to a new fixed value regardless of who builds and provides the image.

Anyone wanting to change the value on a firmware image they build can do so for all images they build by adding a Kconfig in the site-local directory that updates the string to the new value.