[coreboot-gerrit] Change in coreboot[master]: soc/intel/../thermal: Add support for thermal config behind PMC device

[Subrata Banik (Code Review)]

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Patrick Rudolph, EricR Lai.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59209 )

Change subject: soc/intel/../thermal: Add support for thermal config behind PMC device
......................................................................

Patch Set 8:

(1 comment)

File src/soc/intel/common/block/thermal/thermal.c:

https://review.coreboot.org/c/coreboot/+/59209/comment/916e02d7_4b901fbd 
PS8, Line 112: struct pmc_thermal_config {
             : 		void (*func)(uintptr_t addr, uint32_t data);
             : 		uint16_t offset;
             : 		uint32_t value;
             : 	} config[] = {
             : 		{
             : 			.func = thermal_or32,
             : 			.offset = PMC_PWRM_THERMAL_CTEN,
             : 			.value = PMC_PWRM_THERMAL_CTEN_CPDEN | PMC_PWRM_THERMAL_CTEN_CTENLOCK,
             : 		},
             : 		{
             : 			.func = thermal_or32,
             : 			.offset = PMC_PWRM_THERMAL_ECRPTEN,
             : 			.value = PMC_PWRM_THERMAL_ECRPTEN_EN_RPT
             : 					 | PMC_PWRM_THERMAL_ECRPTEN_ECRPTENLOCK,
             : 		},
             : 		{
             : 			.func = write32p,
             : 			.offset = PMC_PWRM_THERMAL_TL,
             : 			.value = pch_get_ltt_value(dev) | PMC_PWRM_THERMAL_TL_TTEN
             : 					 | PMC_PWRM_THERMAL_TL_TLLOCK,
             : 		},
             : 		{
             : 			.func = thermal_or32,
             : 			.offset = PMC_PWRM_THERMAL_PHLC,
             : 			.value = PMC_PWRM_THERMAL_PHLC_PHLCLOCK,
             : 		},
             : 		{
             : 			.func = thermal_or32,
             : 			.offset = PMC_PWRM_THERMAL_TLEN,
             : 			.value = PMC_PWRM_THERMAL_TLEN_TLENLOCK,
             : 		},
             : 	};
> I kind like this structure, like we do the thermal config. […]

almost same reason @Eric.
Will wait for Tim to also share his thoughts on this.

before that I will changes thermal_or32 -> setbits32 as highlighted