Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47381 )
Change subject: drivers/analogix: add MIPI rx flow ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@9 PS2, Line 9: special platform platforms
BTW, is this related to panel? If yes then you should replace 'platform' by 'panel'.
And if this is specific to some platform (board), we should refactor so the driver can take an extra parameter for delay/wait.
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@10 PS2, Line 10: linux driver why is this related to linux driver?
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@10 PS2, Line 10: needs wait needs to wait
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@11 PS2, Line 11: till until
https://review.coreboot.org/c/coreboot/+/47381/2//COMMIT_MSG@11 PS2, Line 11: Based on the test well... a random 800ms sounds unreasonable. I think we need more data, either from data sheet or some where else, to explain why 800ms is the right choice.