Bryant Ou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40547 )
Change subject: mb/ocp/tiogapass: Add SMBIOS type8 data table ......................................................................
Patch Set 2:
(5 comments)
Patch Set 1:
(5 comments)
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... File src/mainboard/ocp/tiogapass/ramstage.c:
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 28: * Internal Reference Designator,
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 29: * Internal Connector Type,
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 30: * External Reference Designator,
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 31: * External Connector_Type,
please, no space before tabs
Done
https://review.coreboot.org/c/coreboot/+/40547/1/src/mainboard/ocp/tiogapass... PS1, Line 32: * Port Type
please, no space before tabs
Done