Attention is currently required from: Karthik Ramasubramanian, Naveen M, Paul Menzel, Pranava Y N.
Varun Upadhyay has posted comments on this change by Varun Upadhyay. ( https://review.coreboot.org/c/coreboot/+/85282?usp=email )
Change subject: drivers/soundwire/alc711: Add common Kconfig for ALC7xx soundwire codecs ......................................................................
Patch Set 8:
(2 comments)
File src/drivers/soundwire/alc711/alc711.c:
https://review.coreboot.org/c/coreboot/+/85282/comment/39cacf53_ea279fab?usp... : PS7, Line 110: config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_1; : config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_NONE; : } else { : config->alc711_address[dev->path.generic.id].version = SOUNDWIRE_VERSION_1_2; : config->alc711_address[dev->path.generic.id].class = MIPI_CLASS_SDCA;
Please set these in the devicetree itself.
hi Karthik, The version & class are only changing for ALC711 to maintain backward compatibility while for ALC721 and ALC722 its same so it doesnt make sense to update from devicetree currently.
File src/drivers/soundwire/alc711/chip.h:
https://review.coreboot.org/c/coreboot/+/85282/comment/6a8e8b65_cbcd1965?usp... : PS7, Line 13: [MAX_SNDW_LINKS]
In your previous iteration of the change, there was only one instance of the alc711_address. […]
hi Karthik, Platform can support multiple ALC7xx soundwire links, previous refractor soundwire ALC711 Kconfig implementation didn't supported multiple codecs without separate variants but with devicetree we can enable multiple ALC7xx codecs based on FW_CONFIGs so adding multiple instances to support that. This CL(85440) shows multiple ALC7xx codecs for one board while hardware connection details are part of crosbug(368495490).