Attention is currently required from: Karthik Ramasubramanian. Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62599 )
Change subject: mb/google/guybrush: Enable EC SMI handler ......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/guybrush/ec.c:
https://review.coreboot.org/c/coreboot/+/62599/comment/95883fc8_05a0ffc1 PS2, Line 35: configure_smi(SMITYPE_ESPI_SMI, SMI_MODE_SMI);
Yeah, we could probably remove that as well if we disable the SMI handler when depthcharge starts.
So one unintended side effect, is that when we boot with the lid closed, the SMI triggers, and when we initialize SMM it handles the SMI. The system seems to be in a strange state at this point. It can't seem to handle the shutdown call, so it causes a reboot. Will need to investigate more. We either need to delay setting the EC SMI mask until after SMM is setup completely, or figure out why we can't `poweroff` in early SMM.