Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39313 )
Change subject: soc/intel/tigerlake: Remove redundant code from graphics.c
......................................................................
Patch Set 13:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39313/6//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39313/6//COMMIT_MSG@11
PS6, Line 11: be executed and we don't need to program DDI_BUF_CTL.
Why? Who programs it?
changed commit message according to new changes
https://review.coreboot.org/c/coreboot/+/39313/6//COMMIT_MSG@12
PS6, Line 12: Hence move the check before DDI_BUF_CTL programming.
Hence fits on the line above.
changed commit message according to new changes
https://review.coreboot.org/c/coreboot/+/39313/6//COMMIT_MSG@14
PS6, Line 14: it
Before or after?
changed commit message according to new changes
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39313
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I32692501b60f48a07b8fbb9bb3a755b18f4b3ea9
Gerrit-Change-Number: 39313
Gerrit-PatchSet: 13
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Srinidhi N Kaushik
srinidhi.n.kaushik@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Mar 2020 11:03:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment