[coreboot-gerrit] Change in coreboot[master]: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms

[Caveh Jalali (Code Review)]

Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43980 )

Change subject: soc/intel/tigerlake: Configure TCSS D3Cold for pre-QS and QS platforms
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/43980/2/src/soc/intel/tigerlake/fsp... 
File src/soc/intel/tigerlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/43980/2/src/soc/intel/tigerlake/fsp... 
PS2, Line 119: 	cpu_id = cpu_get_cpuid();
             : 	if (cpu_id == CPUID_TIGERLAKE_A0)
             : 		params->D3ColdEnable = 0;
             : 	else
> Depends on if we will have any variant that has some boards with pre-QS and other with QS.

we have dedicated variants for ES2 vs. QS SoCs - i.e. A0 vs. B0 silicon.
is there additional granularity we need to handle that can't be addressed
with the variant specific overridetree.cb?