Attention is currently required from: Alper Nebi Yasak, Arthur Heymans, Benjamin Doron, CoolStar, David Hendricks, David Milosevic, Jan Samek, Lean Sheng Tan, Martin L Roth, Maximilian Brune, Patrick Rudolph, Paul Menzel, Simon Glass.
Felix Singer has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/78913?usp=email )
Change subject: payloads: Add leanefi payload
......................................................................
Patch Set 7: Code-Review+2
(4 comments)
Patchset:
PS7:
I am still unhappy about this, particularly given all the work to make U-Boot function as a better coreboot payload. Should I give up on that? This really is not building bridges between the projects. This whole payload seems to make no sense to me, other than trying to avoid using U-Boot.
No, no one suggests that you should give up the work. I think the source of this discussion is just that something is needed now, while improving and/or changing U-Boot to fit the needs takes more time. I just re-read the whole discussion and people suggested many things you all can collaborate on in the long-term, and maybe even U-Boot will fit the needs from here in the future as well. Max even started with using U-Boot, but it just didn't fit the needs. So we should look at the big picture.
A quick look at the source files shows no acknowledgement of U-Boot (BTW that is the correct spelling, bot u-boot). It should be a the top of each file, showing the file it came from.
AFAICS credits to related source files were added one day after your comment. https://review.coreboot.org/plugins/gitiles/leanefi/+/c4d60afb027dc7924034f0...
File payloads/external/leanefi/Kconfig:
PS7:
Missing SPDX license identifier. Please add it in a follow-up.
File payloads/external/leanefi/Kconfig.name:
PS7:
Missing SPDX license identifier. Please add it in a follow-up.
File payloads/external/leanefi/Makefile:
PS7:
Missing SPDX license identifier. Please add it in a follow-up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78913?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I4093378e89c3cb43fb0846666de80a7da36b03f1
Gerrit-Change-Number: 78913
Gerrit-PatchSet: 7
Gerrit-Owner: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: CoolStar
coolstarorganization@gmail.com
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ron Minnich
rminnich@gmail.com
Gerrit-Reviewer: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: David Milosevic
David.Milosevic@9elements.com
Gerrit-CC: Jan Samek
samekh@email.cz
Gerrit-CC: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Jan Samek
samekh@email.cz
Gerrit-Attention: Alper Nebi Yasak
alpernebiyasak@gmail.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: CoolStar
coolstarorganization@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Tue, 04 Jun 2024 00:23:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Simon Glass
sjg@chromium.org