Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34808 )
Change subject: cpu/intel: Refactor platform_enter_postcar() ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... File src/cpu/intel/car/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/2/src/cpu/intel/car/romstage.... PS2, Line 69: run_postcar_phase(&early_mtrrs);
Why not just put this into the function above and name it a little differently? […]
I am anticipating for the possibility of falling through to exit_car.S in romstage, and re-enter romstage to call run_ramstage(). Requires enabling new MTRRs without calling wbinvd, and also platform where eviction can be avoided. The 'save couple milliseconds by skipping postcar' approach.
https://review.coreboot.org/c/coreboot/+/34808/2/src/soc/intel/baytrail/roms... File src/soc/intel/baytrail/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/34808/2/src/soc/intel/baytrail/roms... PS2, Line 54: static void fill_postcar_frame(struct postcar_frame *pcf);
Was this going to be converted to use the other stuff? If not, why not just put everything into a si […]
I am anticipating this platform would be converted to use cpu/intel/romstage.c for the romstage_main(), so this matches the structure.