Nico Huber has posted comments on this change. ( https://review.coreboot.org/21178 )
Change subject: sb/intel/bd82x6x: make hotplug map consistent to remapped ports ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c File src/southbridge/intel/bd82x6x/pch.c:
https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@... PS4, Line 312: old_hotplug_map Using `config->pcie_hotplug_map` here instead would make it more clear, IMHO (e.g. you don't need the implicit information where `old_hotplug_map` points to, to see what is going on).
(The comment doesn't help to see that either.)
https://review.coreboot.org/#/c/21178/4/src/southbridge/intel/bd82x6x/pch.c@... PS4, Line 419: pch_pcie_devicetree_update(); If you pass `config` here, you can probably drop all the if's above.