[coreboot-gerrit] Change in coreboot[master]: Program loading: Handoff cbmem_top via calling arguments

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36272 )

Change subject: Program loading: Handoff cbmem_top via calling arguments
......................................................................

Patch Set 2:
> Patch Set 2:
> > Patch Set 2:
> > > Patch Set 2:
> > >
> > > How does SMM reach cbmem_top()? If I am not mistaken ASEG SMM (AGESA,PI,QEMU-Q35) is not rmodule either, in case that matters.
> >
> > Hmm. I guess the answer is SMM does not have to, and it did not reach it before either.
>
> Looks like the residual smihandler does not need it. It should be rather easy to provide an implementation however, via an apmc call.
>
> Btw with parallel_mp the smm relocation code calls in ramstage code. which knows where cbmem is, which in turn also allows it to print to the cbmem console.

Currently, even with DEBUG_SMI=y, SMM would not output to CBMEM console. I was just a bit surprised to notice SMI did not have CBMEM access at all.