Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43474 )
Change subject: mb/google/zork: Drop redundant romstage GPIO table
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43474/1/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c:
https://review.coreboot.org/c/coreboot/+/43474/1/src/mainboard/google/zork/v...
PS1, Line 146: return gpio_set_stage_rom:
spaces required around that ':' (ctx:VxE)
s/:/;/
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43474
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I67ca9f587c3f47912393ebaf38badcc9d76cc393
Gerrit-Change-Number: 43474
Gerrit-PatchSet: 1
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 15 Jul 2020 15:05:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment