Attention is currently required from: Patrick Rudolph, Christian Walter, Arthur Heymans, Kyösti Mälkki, Werner Zeh.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58240 )
Change subject: drivers/pc80/tpm: Use stopwatch for timeout-loops
......................................................................
Patch Set 1: -Code-Review
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58240/comment/56cd2999_15f3bcd0
PS1, Line 20: TEST=Enable TPM debug messages on a board where the TPM hits a timeout
: by failure and make sure that the debug messages occur in the log
: just in the timeout period.
Regarding the polling frequency issue Kyösti pointed out, do things still work properly without debug messages?
File src/drivers/pc80/tpm/tis.c:
https://review.coreboot.org/c/coreboot/+/58240/comment/7c346dd5_e34eb620
PS1, Line 257: udelay(1); /* 1 us */
With removal of udelay() this will now poll the status as fast as it can, intentional change?
Good point. I'd simply keep the `udelay(1);` inside the loop, just to be safe.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58240
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8fd261c9d60a9a60509c847dbc4983bc05f41d48
Gerrit-Change-Number: 58240
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Comment-Date: Tue, 12 Oct 2021 10:04:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment