[coreboot-gerrit] Change in coreboot[master]: intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34255 )

Change subject: intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER
......................................................................

intel/fsp_baytrail: Avoid preprocessor with HAVE_SMI_HANDLER

The code should probably set SCI routing if built
with HAVE_SMI_HANDLER=n.

Change-Id: I0ada4b2a16490a15d8036a9425c4f768f7b8f218
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34255
Tested-by: build bot (Jenkins) 
Reviewed-by: Angel Pons 
---
M src/soc/intel/fsp_baytrail/gpio.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, approved

diff --git a/src/soc/intel/fsp_baytrail/gpio.c b/src/soc/intel/fsp_baytrail/gpio.c
index 8d4e090..2409eaa 100644
--- a/src/soc/intel/fsp_baytrail/gpio.c
+++ b/src/soc/intel/fsp_baytrail/gpio.c
@@ -192,6 +192,10 @@
    uint32_t route_reg = 0;
    int i;

+	/* FIXME: SCI interrupts should be routed regardlessy. */
+	if (!CONFIG(HAVE_SMI_HANDLER))
+		return;
+
    for (i = 0; i < 8; i++) {
    	/* SMI takes precedence and wake_en implies SCI. */
    	if (sus[i].smi) {
@@ -207,9 +211,7 @@
    	}
    }

-#if CONFIG(HAVE_SMI_HANDLER)
    southcluster_smm_save_gpio_route(route_reg);
-#endif
 }

static void setup_dirqs(const u8 dirq[GPIO_MAX_DIRQS],