build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35365 )
Change subject: emulation/qemu-i440fx: use fw_cfg_dma for fw_cfg_read ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg.c:
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... PS4, Line 533: ? (uint32_t)(dma_desc_addr >> 32) : 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... PS4, Line 533: ? (uint32_t)(dma_desc_addr >> 32) : 0; please, no space before tabs
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... PS4, Line 533: ? (uint32_t)(dma_desc_addr >> 32) : 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... PS4, Line 540: while (be32_to_cpu(dma.control) & ~FW_CFG_DMA_CTL_ERROR); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... File src/mainboard/emulation/qemu-i440fx/fw_cfg_if.h:
https://review.coreboot.org/c/coreboot/+/35365/4/src/mainboard/emulation/qem... PS4, Line 84: char name[FW_CFG_MAX_FILE_PATH]; please, no spaces at the start of a line