Attention is currently required from: Julius Werner, Martin L Roth.
Nico Huber has posted comments on this change by Martin L Roth. ( https://review.coreboot.org/c/coreboot/+/83118?usp=email )
Change subject: Kconfig: Remove prompt for FW_CONFIG_SOURCE_CHROMEEC_CBI
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/Kconfig:
https://review.coreboot.org/c/coreboot/+/83118/comment/12e27770_9b4b4cd7?usp... :
PS1, Line 509: bool "Firmware Configuration Probing"
This looks spurious too. Isn't it that the respective board ports actually need it?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83118?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Icf170dc2ef790d6f5a897a9c7c2ea64033bf1dc9
Gerrit-Change-Number: 83118
Gerrit-PatchSet: 1
Gerrit-Owner: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Fri, 21 Jun 2024 13:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes