Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43160 )
Change subject: sb/intel/i82801gx/acpi/globalnvs.h: Add some Offset lines ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG@7 PS1, Line 7: h hell, you are drunk
https://review.coreboot.org/c/coreboot/+/43160/1//COMMIT_MSG@10 PS1, Line 10:
This basically reverts commit 80505a6fef (sb/intel/i82801gx: Remove unnecessary/redundant ACPI offse […]
Ah, just learned of that change. In any case, having them makes the ASL code easier to follow. Otherwise, one needs to count the bits from the last Offset line. Plus, it makes the globalnvs.asl files identical, which is nice.
Want me to do anything about it?