Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34188 )
Change subject: mb/google/octopus/variants/garg: support LTE power sequence ......................................................................
Patch Set 12:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34188/11//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34188/11//COMMIT_MSG@8 PS11, Line 8:
Referring to other practice, I split CLs for adding each variant APIs above.
That's perfect :). Thanks for doing that.
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... PS11, Line 346: UP_20K
Just copy the original GPIO configuration from line 231 in gpio_table as the defautl stage.
Ah I see. I think we should clean up the UP_20K from here and gpio_table as a follow up.
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... File src/mainboard/google/octopus/variants/garg/gpio.c:
https://review.coreboot.org/c/coreboot/+/34188/11/src/mainboard/google/octop... PS11, Line 110: lte_early_override_table
Yes, as my previous comment to Karthik. […]
Thanks for confirming.