Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41247 )
Change subject: soc/amd/common/block/lpc: Add lpc_initialize_spi_bar() ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41247/3/src/soc/amd/common/block/in... File src/soc/amd/common/block/include/amdblocks/lpc.h:
https://review.coreboot.org/c/coreboot/+/41247/3/src/soc/amd/common/block/in... PS3, Line 195: lpc_initialize_spi_bar
I kept it this way so that the existing callers can just use lpc_initialize_spi_bar() to do the same […]
I think it would be cleaner. As someone who wants to use this API I need to stop and wonder why I would use lpc_set_spibase() over lpc_initialize_spi_bar(..., 0), or if there is something preventing me from calling lpc_initialize_spi_bar(..., 1) from the very beginning.