Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32765 )
Change subject: Use !ENV_PAYLOAD_LOADER to select __SIMPLE_DEVICE__
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/32765/2/src/include/rules.h
File src/include/rules.h:
https://review.coreboot.org/#/c/32765/2/src/include/rules.h@266
PS2, Line 266: The reason
: * post-CAR utilizes __SIMPLE_DEVICE__ is for simplicity
post-CAR utilizes __SIMPLE_DEVICE__ only if it is not a payload loader stage.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32765
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ide61ec2c908758ba96c61ca9ed7278e7d11d1ee5
Gerrit-Change-Number: 32765
Gerrit-PatchSet: 2
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Mon, 13 May 2019 16:48:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment