Attention is currently required from: Arthur Heymans, Elyes HAOUAS, Maximilian Brune, Ronak Kanabar, Sridhar Siricilla, Subrata Banik.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76878?usp=email )
Change subject: arch/x86: Adjust stack pointer to point to dummy argument ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/76878/comment/f5d429b6_b9dadf6a : PS1, Line 8: I’d start by describing the problem.
https://review.coreboot.org/c/coreboot/+/76878/comment/7533bd23_80bdc55c : PS1, Line 10: as depthcharge picks the : second element from top of the stack as coreboot table address Please reference the source code file/line in depthcharge, where this is done.
https://review.coreboot.org/c/coreboot/+/76878/comment/9de3d938_a8417904 : PS1, Line 16: TEST=Tested in simics environment.64bit coreboot could boot : to OS. Please add a space after the dot/period, and also everything fits into 72 characters.
File src/arch/x86/c_exit.S:
https://review.coreboot.org/c/coreboot/+/76878/comment/5ff33c61_24d24ad6 : PS1, Line 34: pushl $0 /* Dummy argument */ Maybe mention depthcharge here too?