Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Jakub Czapiga, Stefan Reinauer, Michal Zygowski.
Karol Zmyslowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake ......................................................................
Patch Set 17:
(7 comments)
Patchset:
PS17: I've corrected mentioned mistakes.
File util/inteltool/gpio_names/jasperlake.h:
https://review.coreboot.org/c/coreboot/+/73934/comment/10baea37_165f208b PS17, Line 15: "ESPI_RESET,_N",
"ESPI_RESET_N"
Done
https://review.coreboot.org/c/coreboot/+/73934/comment/55eddf72_17d1aafb PS17, Line 18: "SMB_ALERT_,N",
"SMB_ALERT_N"
Done
https://review.coreboot.org/c/coreboot/+/73934/comment/c4f3df36_30615f0d PS17, Line 148: "GPP_L_BKLTEN", "GPP_L_BKLTEN", : "GPP_L_BKLTCTL", "GPP_L_BKLTCTL", : "GPP_LVDDEN", "GPP_LVDDEN", : "GPP_SYS_PWROK", "GPP_SYS_PWROK", : "GPP_SYS_RESETB", "GPP_SYS_RESETB", : "GPP_MLK_RSTB", "GPP_MLK_RSTB",
These pins should not have GPP_ prefix
Done
https://review.coreboot.org/c/coreboot/+/73934/comment/d2397e30_992d104a PS17, Line 157: GPP_HVCMOS
Just HVCMOS
Done
https://review.coreboot.org/c/coreboot/+/73934/comment/e67e6123_9330e54c PS17, Line 503: const char *const jasperlake_pch_group_vgpio_padding_names [] ={
Just jasperlake_pch_group_vgpio_names and jasperlake_pch_group_vgpio […]
Done
https://review.coreboot.org/c/coreboot/+/73934/comment/ae16852d_60daadf0 PS17, Line 554: "GPD_INPUT3VSEL", "GPD_INPUT3VSEL", : "GPD_SLP_SUSB", "GPD_SLP_SUSB", : "GPD_WAKEB", "GPD_WAKEB", : "GPD_DRAM_RESETB", "GPD_DRAM_RESETB",
These should not have GPD_ prefix
Done