Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36553 )
Change subject: soc/intel/tigerlake/acpi: Copy acpi directory from icelake ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/gpio.asl:
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp... PS1, Line 40: ^ This makes this hard to read, I'd have to look up the scope where this is defined and find this object in that scope. Please reference the path's absolute.
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp... PS1, Line 85: LAnd (LGreaterEqual (Arg0, GPP_G0), LLessEqual (Arg0, GPP_A23) Please use the new ASL syntax. Arg0 >= GPP_G0 && Arg0 <= GPP_A23
https://review.coreboot.org/c/coreboot/+/36553/1/src/soc/intel/tigerlake/acp... PS1, Line 87: Store (PID_GPIOCOM0, Local0) Local0 = PID_GPIOCOM0