Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30796
Change subject: arch/x86/lapic: Remove second stack poisoning ......................................................................
arch/x86/lapic: Remove second stack poisoning
It was already done once in c_start.S.
Change-Id: I1cb0ea25251644dbd1127d177247a02ba52bb550 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/cpu/x86/lapic/lapic_cpu_init.c 1 file changed, 2 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/30796/1
diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 0a51a08..cf61530 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -269,7 +269,6 @@ unsigned long apicid; unsigned int index; unsigned long count; - int i; int result;
spin_lock(&start_cpu_lock); @@ -287,10 +286,8 @@ stack_base = ((unsigned long)_estack) - (CONFIG_STACK_SIZE*(index+1)); printk(BIOS_SPEW, "CPU%d: stack_base %p, stack_end %p\n", index, (void *)stack_base, (void *)stack_end); - /* poison the stack */ - for (stack = (void *)stack_base, i = 0; i < CONFIG_STACK_SIZE; i++) - stack[i/sizeof(*stack)] = 0xDEADBEEF; - stacks[index] = stack; + stacks[index] = (void *)stack_base; + /* Record the index and which CPU structure we are using */ info = (struct cpu_info *)stack_end; info->index = index;