Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33143 )
Change subject: Rampayload: Able to build coreboot without ramstage
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33143/3/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/#/c/33143/3/Makefile.inc@1062
PS3, Line 1062: $(obj)/coreboot.rom: $(obj)/coreboot.pre $(CBFSTOOL) $$(INTERMEDIATE)
Why not just introduce a variable that is empty if RAMPAYLOAD is 'y' and set to $(objcbfs)/ramstage. […]
Done
https://review.coreboot.org/#/c/33143/3/Makefile.inc@1136
PS3, Line 1136: cbfs-files-y += $(CONFIG_CBFS_PREFIX)/ramstage
Technically, only this particular line needs to be guarded, fwiw. But you don't have to change it.
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33143
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id000dfac2eb57a8eaaa505c89d798fb30b3706fe
Gerrit-Change-Number: 33143
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 03 Jun 2019 09:57:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment