17 Jan
2021
17 Jan
'21
1:38 p.m.
Attention is currently required from: Angel Pons, HAOUAS Elyes. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel: Introduce MCHBAR accessor functions ......................................................................
Patch Set 41:
(1 comment)
File src/northbridge/intel/common/mchbar_ops.h:
https://review.coreboot.org/c/coreboot/+/45517/comment/21ba1ab9_e64d239c PS37, Line 27: (u8)
Jenkins needs that mask.
What is that supposed to mean? would checkpatch complain otherwise? would the compiler complain? is it covering up bugs?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45517
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5
Gerrit-Change-Number: 45517
Gerrit-PatchSet: 41
Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Comment-Date: Sun, 17 Jan 2021 13:38:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes ehaouas@noos.fr
Gerrit-MessageType: comment