Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41030 )
Change subject: soc/intel/gpio: set default value for RXEVCFG in native mode ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41030/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41030/1//COMMIT_MSG@9 PS1, Line 9: (Intel document #549921
I want to say apollolake, skylake, or glk. I did a brief search and found apollolake had an issue on LPC block: https://review.coreboot.org/c/coreboot/+/16426 That was involving the termination pulls. I recall an EMMC issue as well, however I didn't hvae time to dig that one up.
Termination in the case of native functions is badly documented. There's a little word in the register description:
1111: (optional) Native controller selected by Pad Mode controls the Termination
AFAICT, this "optional" means that only some NFs support this. And I can't find more documentation which these are.
Apart from this, everything seems to be documented. Most descriptions of register fields mention if they are meaningful in NF or GPIO mode. And I see no clue that any fields would be automatically changed by the hardware, only that the hardware will ignore certain fields in one mode or another.
Anyway, I don't like this change either. We shouldn't add complexity for cosmetic reasons.