Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35598 )
Change subject: fsp_broadwell_de: Enable early write access to the SPI flash
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/35598/1/src/soc/intel/fsp_broadwell...
File src/soc/intel/fsp_broadwell_de/Kconfig:
https://review.coreboot.org/c/coreboot/+/35598/1/src/soc/intel/fsp_broadwell...
PS1, Line 32: select BOOT_DEVICE_SUPPORTS_WRITES
shouldn't this depend on VBOOT?
It's the opposite. VBOOT_VBNV_FLASH depends on BOOT_DEVICE_SUPPORTS_WRITES.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35598
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I90a2d30f5749c75df2b286dce6779f10dde62632
Gerrit-Change-Number: 35598
Gerrit-PatchSet: 1
Gerrit-Owner: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: Andrey Petrov
anpetrov@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 26 Sep 2019 17:53:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Andrey Petrov
anpetrov@fb.com
Gerrit-MessageType: comment