Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41987 )
Change subject: [WIP] sb,soc/intel: Consolidate set_acpi_mode()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41987/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41987/2//COMMIT_MSG@7
PS2, Line 7: [WIP] sb,soc/intel: Consolidate set_acpi_mode()
Would be good to note that some chipsets only perform one of the two branches.
Currently pretty much nothing builds with HAVE_SMI_HANDLER=n. This calls for some discussion on what we actually need to do here.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41987
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50bdce6a8e9043b209c5558b5ab613f945b4b787
Gerrit-Change-Number: 41987
Gerrit-PatchSet: 2
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sun, 07 Jun 2020 09:36:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment